store split_fields in split #4190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
force-pushed
the
list_fields
branch
6 times, most recently
from
d93ed7a
to
d76e27e
Compare
fulmicoton
reviewed
Nov 24, 2023
| @@ -5528,6 +5528,7 @@ dependencies = [ | |||
| "ulid", | |||
| "utoipa", | |||
| "vrl", | |||
| "zstd 0.13.0", | |||
There was a problem hiding this comment.
we have several version of zstd?
There was a problem hiding this comment.
ah yes. so zstd 0.11 is pulled by lindera's build deps.
0.13 is correct.
fulmicoton
reviewed
Nov 24, 2023
fulmicoton
reviewed
Nov 24, 2023
fulmicoton
reviewed
Nov 24, 2023
fulmicoton
reviewed
Nov 24, 2023
fulmicoton
reviewed
Nov 24, 2023
| @@ -116,13 +117,14 @@ impl SplitPayloadBuilder { | |||
| /// Creates a new SplitPayloadBuilder for given files and hotcache. | |||
| pub fn get_split_payload( | |||
| split_files: &[PathBuf], | |||
| serialized_split_fields: &[u8], | |||
There was a problem hiding this comment.
You wanted really hard to avoid writing on the file system?
There was a problem hiding this comment.
Just seemed unnecessary and wasn't much effort. If there's another case, we probably should refactor it to something like
enum SplitFile{
OnDisk(PathBuf),
InMemory(String, Vec<u8>)
}There was a problem hiding this comment.
So if I recall correctly, down the stream, we build a PutPayload off these files.
Would it be possible to carry a PutPayload earlier maybe?
There was a problem hiding this comment.
I moved it earlier in the code
fulmicoton
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.